Open
Conversation
Enable session based on cookie
This should be good enough for testing. Can be changed to SSE later.
Required by starlette to serve static files
Do not pin dependencies in setup.py (use requirements.txt for that)
Add web ui See merge request kits-maxiv/kubernetes/notify/notify-server!3
Fix tests new pydantic See merge request kits-maxiv/kubernetes/notify/notify-server!6
Add realm discovery endpoint See merge request kits-maxiv/kubernetes/notify/notify-server!14
Move to python 3.14
Update requirements and python See merge request kits-maxiv/kubernetes/notify/notify-server!15
beenje
force-pushed
the
add-demo-realm
branch
from
5ebc927 to
6640f0e
Compare
beenje
force-pushed
the
add-demo-realm
branch
from
6640f0e to
2635505
Compare
Collaborator
Author
|
If you are interested, here are our mobile apps that we updated to login via OpenId connect: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the mobile app to be validated when submitting it to the App Store/Play Store, external users need to be able to login using OpenId Connect. We added a "demo" realm that can be used for this purpose (without 2FA).
There is a new endpoint to discover the realm (
realordemo) that should be used from the mobile app.No configuration regarding the keycloak realm is needed in the mobile app.
We also introduced a
DEMO_ACCOUNT_USERNAMEvariable to be able to use another username thandemo.Those changes shouldn't have any impact when using
OIDC_ENABLED: False.Note that the branch used at MAX IV had diverged. I did a merge, hence the high number of commits.